Review Request 109037: Port the ConversationsModel::startChat to KTP::Contacts
David Edmundson
david at davidedmundson.co.uk
Tue Feb 19 02:27:12 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109037/#review27702
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Feb. 19, 2013, 2:25 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109037/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2013, 2:25 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Otherwise we can't start chats from a pinned contact
>
>
> Diffs
> -----
>
> KTp/Declarative/conversations-model.h 3dd8a1b
> KTp/Declarative/conversations-model.cpp a87a7de
>
> Diff: http://git.reviewboard.kde.org/r/109037/diff/
>
>
> Testing
> -------
>
> I could start conversations with pinned contacts after the patch, before I got a warning about an unknown Tp::ContactPtr.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130219/546e2559/attachment-0001.html>
More information about the KDE-Telepathy
mailing list