Review Request 109032: Catch all cases where the window is hidden

David Edmundson david at davidedmundson.co.uk
Tue Feb 19 01:35:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109032/#review27694
-----------------------------------------------------------

Ship it!


Well spotted.


chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml
<http://git.reviewboard.kde.org/r/109032/#comment20750>

    {}


- David Edmundson


On Feb. 19, 2013, 1:19 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109032/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 1:19 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> We were omitting the case where the user would close the dialog by pressing esc, this is not the case anymore.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml 09049a3 
> 
> Diff: http://git.reviewboard.kde.org/r/109032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130219/538e57aa/attachment.html>


More information about the KDE-Telepathy mailing list