Review Request 108991: set focus on the password field

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108991/#review27576
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Klapetek


On Feb. 17, 2013, 12:44 p.m., Stefan Eggers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108991/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2013, 12:44 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> set focus on the password field
> 
> Previously when the dialog opened the focus was on the OK button and
> one had to click on the KLineEdit widget to enter the password. With
> this change the foucs is on the KLineEdit widget instead and one can
> start to enter the password right away.
> 
> In addition to this make sure the dialog doesn't steal focus. Other-
> wise it might interrupt text input in some other window when it opens.
> 
> 
> This addresses bug 312338.
>     http://bugs.kde.org/show_bug.cgi?id=312338
> 
> 
> Diffs
> -----
> 
>   x-telepathy-password-prompt.cpp 7f2be8117e0d0a98c2f345780e7bc19831697a89 
> 
> Diff: http://git.reviewboard.kde.org/r/108991/diff/
> 
> 
> Testing
> -------
> 
> Testing without this change showed that the OK button had focus when the password dialog opened. With this change the input field for the password has focus.
> 
> As for the issue of the dialog stealing the focus I tested logging in with a KDE session which previously had Konsole open. I made sure the password dialogs were not open when logging out. After Konsole starts I begin typing some random text on the command line while waiting for the password dialog to open. The password dialog opened in the background and did not interrupt text input in Konsole with this change.
> 
> 
> Thanks,
> 
> Stefan Eggers
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130217/aeaf11a2/attachment-0001.html>