Review Request 106763: Improve contact list group header

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106763/
-----------------------------------------------------------

(Updated Feb. 17, 2013, 11:30 a.m.)


Review request for Telepathy and KDE Usability.


Changes
-------

Take two.

I moved the expand sign back to the left and the group/account icon to the right. The colors are button colors with the background lightened by the factor of 5. There's also a subtle line at the bottom of the header, using normal button color. See screenshot.


Description
-------

I made several improvements to the group header in contact list:

 1) Moved the expand sign to the right
 2) Removed the tiny line
 3) Made the account/group icon slightly bigger (has the same size as the avatar in normal mode; might need adjusting)
 4) Aligned both the icon and the font with the contacts
 5) Used background color from palette disabled:highlight and lighter by factor of 10

This is more a visual review request than a code, I tried with several default KDE color schemes and I think it looks good in all of them, see the screenshot below. Let me know what you think (and if possible try using the patch for a while yourself and see how it fits).


Diffs (updated)
-----

  abstract-contact-delegate.cpp 836913f 

Diff: http://git.reviewboard.kde.org/r/106763/diff/


Testing
-------


File Attachments (updated)
----------------

Take Two
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/headers_2.png


Screenshots
-----------

New group header
  http://git.reviewboard.kde.org/r/106763/s/757/


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130217/61170807/attachment.html>