Review Request 108960: Support multiple file transfer sending from send-file

[Andrea Scarpino]

> On Feb. 14, 2013, 5:51 p.m., Dan Vrátil wrote:
> > mainwindow.cpp, line 68
> > <http://git.reviewboard.kde.org/r/108960/diff/1/?file=114027#file114027line68>
> >
> >     This is not translatable. You want to use something like
> >     
> >     i18np("One file selected: %2", "%1 files selected: %2", filesCount, fileNames);

This is shown only when the files are many and not when there's just one.


> On Feb. 14, 2013, 5:51 p.m., Dan Vrátil wrote:
> > mainwindow.cpp, line 92
> > <http://git.reviewboard.kde.org/r/108960/diff/1/?file=114027#file114027line92>
> >
> >     Wouldn't it be better to hide the icon and show only the list of files instead? 
> >     
> >     When you select many files, there will be huge icon and huge list of files => huge dialog. Removing the icon will allow current size dialog even for large amount of files.

IMHO 128px doesn't make a big difference to the dialog size height.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108960/#review27456
-----------------------------------------------------------


On Feb. 14, 2013, 5:02 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108960/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 5:02 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> = summary
> 
> 
> This addresses bug 288557.
>     http://bugs.kde.org/show_bug.cgi?id=288557
> 
> 
> Diffs
> -----
> 
>   ktp-send-file.desktop 9032bda 
>   main.cpp fac970b 
>   mainwindow.h 2c235b7 
>   mainwindow.cpp c968cf0 
> 
> Diff: http://git.reviewboard.kde.org/r/108960/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Send three files from dolphin
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/send-files.png
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130214/5affcddf/attachment.html>