Review Request 108927: Provide a way to turn the presence-changes messages off

[David Edmundson]

> On Feb. 13, 2013, 2:40 p.m., Daniele E. Domenichelli wrote:
> > lib/adium-theme-view.h, lines 62-66
> > <http://git.reviewboard.kde.org/r/108927/diff/3/?file=113915#file113915line62>
> >
> >     The config for group chats is being split into a separate tab (see  http://git.reviewboard.kde.org/r/108571/ ). Therefore I'd suggest to have just one bool for now, instead of an enum. Later we will have 2 different bools in single/group chats. Otherwise we will have to handle the migration of the setting.
> >     
> >     Anyway I would like to hear David's opinion

That does make a lot of sense.
However, this patch was first. So I'll rebase my stuff on top and fix it in mine.


> On Feb. 13, 2013, 2:40 p.m., Daniele E. Domenichelli wrote:
> > config/appearance-config.cpp, line 216
> > <http://git.reviewboard.kde.org/r/108927/diff/3/?file=113913#file113913line216>
> >
> >     You shouldn't hide the /me messages, therefore also the demo chat should reflect this ("Ted Example waves." is a /me message.
> >     
> >     Anyway is the "if" necessary? Is it possible just to let the chat widget handle that? I'd like to see the demo chat just like a sequence of events and see exactly what I would see in the chat ui (but perhaps it's not possible)

The if is needed, the filtering happens in ChatWidget and not in the AdiumThemeView.

Though I agree with DrDanz about not filtering the "/me"


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108927/#review27370
-----------------------------------------------------------


On Feb. 13, 2013, 2:29 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108927/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 2:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implement a way to turn the presence-changes message off based on last David comment in the bug report.
> So, this adds a combobox in the Chat Window Appareance tab.
> 
> 
> This addresses bug 287399.
>     http://bugs.kde.org/show_bug.cgi?id=287399
> 
> 
> Diffs
> -----
> 
>   config/appearance-config.h 5b6c83d 
>   config/appearance-config.cpp a88dd02 
>   config/appearance-config.ui 6a040db 
>   lib/adium-theme-view.h 732cf71 
>   lib/adium-theme-view.cpp 12e0b02 
>   lib/chat-widget.cpp 60efede 
> 
> Diff: http://git.reviewboard.kde.org/r/108927/diff/
> 
> 
> Testing
> -------
> 
> No more presence-changes messages :)
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130213/0b9b82b9/attachment.html>