Review Request 108927: Provide a way to turn the presence-changes messages off

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108927/#review27352
-----------------------------------------------------------



config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/108927/#comment20575>

    Use the values from the ShowPresenceMode enum you have created in AdiumThemeView



config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/108927/#comment20576>

    You should skip this message when the feature is disabled.



config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/108927/#comment20577>

    Use the enum



lib/adium-theme-view.h
<http://git.reviewboard.kde.org/r/108927/#comment20573>

    The type shoule be AdiumThemeView::ShowPresenceMode instead of int



lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/108927/#comment20574>

    Use the enum



lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/108927/#comment20572>

    Use the enum


- Dan Vrátil


On Feb. 12, 2013, 8:59 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108927/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 8:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implement a way to turn the presence-changes message off based on last David comment in the bug report.
> So, this adds a combobox in the Chat Window Appareance tab.
> 
> 
> This addresses bug 287399.
>     http://bugs.kde.org/show_bug.cgi?id=287399
> 
> 
> Diffs
> -----
> 
>   config/appearance-config.h 5b6c83d 
>   config/appearance-config.cpp a88dd02 
>   config/appearance-config.ui 6a040db 
>   lib/adium-theme-view.h 732cf71 
>   lib/adium-theme-view.cpp 12e0b02 
>   lib/chat-widget.cpp 60efede 
> 
> Diff: http://git.reviewboard.kde.org/r/108927/diff/
> 
> 
> Testing
> -------
> 
> No more presence-changes messages :)
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130213/946aa057/attachment-0001.html>