Review Request 108871: Add HasTextChannel and UnreadMessageCount roles to contact list

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108871/#review27212
-----------------------------------------------------------


This review has been submitted with commit a357ec8543aaef77ebd22f20ba4aab1aff5fc5b6 by David Edmundson to branch master.

- Commit Hook


On Feb. 10, 2013, midnight, David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108871/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2013, midnight)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add HasTextChannel and UnreadMessageCount roles to contact list
> 
> Model acts as an QIdentityModel and Tp::AbstractClientObserver for text channels
> on top of contact-list-model.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/CMakeLists.txt 0d305e65739bfe2823ddd5bb6ea6687f236e5846 
>   KTp/Models/text-channel-watcher-proxy-model.h PRE-CREATION 
>   KTp/Models/text-channel-watcher-proxy-model.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108871/diff/
> 
> 
> Testing
> -------
> 
> There is a version in the contact list that works (and is awesome). This contains some slight tweaks + fixes, which are untested.
> 
> I want to add support to ContactsModel to have setTrackMessages(bool); as one of the options, which inserts/removes this as one of the filters. Will do that if/when this passes review.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130211/dc79f97b/attachment.html>