Review Request 108895: Tidy QML Plugins (1/2)

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108895/#review27198
-----------------------------------------------------------



KTp/Declarative/base.h
<http://git.reviewboard.kde.org/r/108895/#comment20482>

    You should stop living in the past, David... :-)



KTp/Models/contacts-list-model.cpp
<http://git.reviewboard.kde.org/r/108895/#comment20485>

    1) You should delete t->contactManager before assigning a new one
    2) I believe it's a convention in Qt that calling set...() with a null pointer resets the property. Just silently doing nothing is confusing from user's point of view.


- Dan Vrátil


On Feb. 11, 2013, 1:37 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108895/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2013, 1:37 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Tidy QML Plugins
> 
> Remove our own declarative ContactsModel class, and simply expose KTp::CommonInternals
> 
> Create a new QML class that can act as the AccountManager. 
> This can then be passed to anything that needs it (the ContactsModel and GlobalPresence and the ConversationsModel/TextObserver)
> 
> See part 2/2 for how it works in practice
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/qml-plugins.cpp bd2a92717489af3ddb4cdc5b6413a2caaf307e92 
>   KTp/Models/contacts-list-model.cpp dfa32870ea501c84bd15c3d2f0df78ef0e501da0 
>   KTp/Models/contacts-model.h 7e91e155a205b5c9dab24470a0e10ef63a087ea6 
>   KTp/Declarative/base.cpp PRE-CREATION 
>   KTp/Declarative/contact-list.h a59814490fd0dc3407e1f6a45266de7e6d89149c 
>   KTp/Declarative/contact-list.cpp 9e05d5c964ace0b6ee657edad6ecd99d0e823ce1 
>   KTp/Declarative/CMakeLists.txt f42252d4fd2d3a7d5d23cd9de110e251a79e4170 
>   KTp/Declarative/base.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108895/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130211/d7dcd629/attachment.html>