Review Request 108881: Pass around Tp::ContactPtr instead of just id

David Edmundson david at davidedmundson.co.uk
Sat Feb 9 23:46:46 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108881/#review27108
-----------------------------------------------------------

Ship it!



abstract-storage.h
<http://git.reviewboard.kde.org/r/108881/#comment20440>

    change the name id


- David Edmundson


On Feb. 9, 2013, 11:43 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108881/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2013, 11:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This allows us to push aliases with the initial push, which means
> that the UI will get contacts with names immediately, otherwise
> we'd see contacts without names and only after the initial feeding
> was done, the alisases would be feeded, causing high(-ish) delay
> before the UI has the aliases. This also causes less model updates
> as all is fetched in one go.
> 
> 
> Diffs
> -----
> 
>   abstract-storage.h 0614336 
>   account.h c09d946 
>   account.cpp d11caef 
>   controller.cpp c1cec56 
>   nepomuk-storage.h 8190a5b 
>   nepomuk-storage.cpp be80e23 
> 
> Diff: http://git.reviewboard.kde.org/r/108881/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130209/b765cb96/attachment-0001.html>


More information about the KDE-Telepathy mailing list