Review Request 108871: Add HasTextChannel and UnreadMessageCount roles to contact list

[David Edmundson]

> On Feb. 9, 2013, 10:46 a.m., Dan Vrátil wrote:
> > Is there any other usecase for the model outside contact list? Could this just be merged into the KTp::ContactsModel or somewhere else? (sorry if I this has been already explained elsewhere)

Usages wil be:
 - contact list
 - contact-list-applet
 - ktp-active

Could it be merged in KTp::ContactsModel?
Assuming you mean KTp::ContactsListModel, not really.
1) because it's not always needed (i.e you wouldn't want this on the "select contact to play kbattleships with" screen)
2) this /should/ work on top of Martin's kpeople model.

Could it be done in ContactsModel?
It /could/ but it would be 10x harder. By adding data() before we go through the groups model we know each contact will only appear once. After the groups grouping, it gets a lot more complicated.


> On Feb. 9, 2013, 10:46 a.m., Dan Vrátil wrote:
> > KTp/Models/text-channel-watcher-proxy-model.cpp, line 180
> > <http://git.reviewboard.kde.org/r/108871/diff/2/?file=113313#file113313line180>
> >
> >     Should the ChannelWatcher be deleted?

oops, yeah. Maybe I should make it Tp::RefCounted so I don't have to worry about these things.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108871/#review27058
-----------------------------------------------------------


On Feb. 9, 2013, 3:02 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108871/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2013, 3:02 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add HasTextChannel and UnreadMessageCount roles to contact list
> 
> Model acts as an QIdentityModel and Tp::AbstractClientObserver for text channels
> on top of contact-list-model.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/CMakeLists.txt 0d305e65739bfe2823ddd5bb6ea6687f236e5846 
>   KTp/Models/text-channel-watcher-proxy-model.h PRE-CREATION 
>   KTp/Models/text-channel-watcher-proxy-model.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108871/diff/
> 
> 
> Testing
> -------
> 
> There is a version in the contact list that works (and is awesome). This contains some slight tweaks + fixes, which are untested.
> 
> I want to add support to ContactsModel to have setTrackMessages(bool); as one of the options, which inserts/removes this as one of the filters. Will do that if/when this passes review.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130209/a5ffb64a/attachment.html>