Review Request 108846: when offline, hide add contact SNI

[David Edmundson]

> On Feb. 8, 2013, 9:56 a.m., Rohan Garg wrote:
> > Ship It!
> 
> Rohan Garg wrote:
>     Code looks fine to me, haven't tested it though.
> 
> Stefan Eggers wrote:
>     As I don't have commit access someone else has to push this change for me.
> 
> Rohan Garg wrote:
>     Will do, just one question, any particular reason why the new connect can't be moved into onNewAccountAdded() ? Since it's in onPresencePublicationRequested right now, the signal will be connected every time I go from Online -> Away -> Busy -> Whatever. Best to just connect it once?

Because we're not monitoring the account, we're monitoring the contact's connection. 
Therefore it's best to do it on the method that deals with "onNewContacts", which is this one.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108846/#review26942
-----------------------------------------------------------


On Feb. 8, 2013, 9:50 a.m., Stefan Eggers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108846/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 9:50 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> when offline, hide add contact SNI
> 
> 
> This addresses bug 294478.
>     http://bugs.kde.org/show_bug.cgi?id=294478
> 
> 
> Diffs
> -----
> 
>   contact-request-handler.h 43456ee8f0a354ed075335d80a125da51713a0e9 
>   contact-request-handler.cpp f40f397e86393716cebf128630b2c4c43691930e 
>   telepathy-module.cpp 7ab13b26f8d52648c2c33c0fde0ff1648181c8c4 
> 
> Diff: http://git.reviewboard.kde.org/r/108846/diff/
> 
> 
> Testing
> -------
> 
> - add two accounts A and B in a local ejabber server
> - account A adds account B to contact list
> - approval request shows up in account B when B comes online
> - stop ejabber server so that B is offline
> - with this patch the approval request does not show anymore while B stays offline; it comes back when B is online again
> 
> 
> Thanks,
> 
> Stefan Eggers
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130208/8706ddb2/attachment-0001.html>