Review Request 108846: when offline, hide add contact SNI

Stefan Eggers coloncolonone at gmail.com
Fri Feb 8 09:50:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108846/
-----------------------------------------------------------

Review request for Telepathy.


Summary (updated)
-----------------

when offline, hide add contact SNI


Description (updated)
-------

when offline, hide add contact SNI


This addresses bug 294478.
    http://bugs.kde.org/show_bug.cgi?id=294478


Diffs (updated)
-----

  contact-request-handler.h 43456ee8f0a354ed075335d80a125da51713a0e9 
  contact-request-handler.cpp f40f397e86393716cebf128630b2c4c43691930e 
  telepathy-module.cpp 7ab13b26f8d52648c2c33c0fde0ff1648181c8c4 

Diff: http://git.reviewboard.kde.org/r/108846/diff/


Testing (updated)
-------

- add two accounts A and B in a local ejabber server
- account A adds account B to contact list
- approval request shows up in account B when B comes online
- stop ejabber server so that B is offline
- with this patch the approval request does not show anymore while B stays offline; it comes back when B is online again


Thanks,

Stefan Eggers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130208/7c6ea2b2/attachment.html>


More information about the KDE-Telepathy mailing list