Review Request 108831: Fix some porting leftovers from the contactlist, some cleanup

Aleix Pol Gonzalez aleixpol at gmail.com
Thu Feb 7 16:35:05 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108831/
-----------------------------------------------------------

Review request for Telepathy and David Edmundson.


Description
-------

This patch does 2 main things:
- cleans up the delegate to use PlasmaComponents.ListItem instead of a custom highlighter.
- Fixes the plasmoid initialization, when setting the sorting and filter. it was using .model instead of .filter. (it wasn't filtering or sorting anything before...)
- Prefer IconItem to QIconItem, this is better because it's a little smarter and more efficient (see marco's blog posts). It has a downside that adds a dependency on KDE 4.10, which I'm unsure if it's acceptable.

Hope you like it!


Diffs
-----

  contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml 2f0ea05 
  contactlist/org.kde.ktp-contactlist/contents/ui/ListContactDelegate.qml 9bf73d8 

Diff: http://git.reviewboard.kde.org/r/108831/diff/


Testing
-------

I ran the contact list on the plasmoid viewer while coding


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130207/03b7f051/attachment.html>


More information about the KDE-Telepathy mailing list