Review Request 108820: Remove account and its contacts from Nepomuk when the account is removed from Tp

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108820/#review26837
-----------------------------------------------------------



nepomuk-storage.cpp
<http://git.reviewboard.kde.org/r/108820/#comment20332>

    Could you simplify the code over here a little. It's hard to understand -
    
    QList<ContactIdentifier> keys = m_contacts.keys(); // Splitting it so that the keys do not need to be reconstructed each time
    
    for( .. ) {
    ContactIdentifier ci = keys.at(i);
    if( ci.accountId() == path ) {
        ContactResources cr = m_contacts.value(ci);
        urisToDelete << cr.personContact();
    }
    }
    Also, should you also delete the imAccount of each of these person contacts?
    
    urisToDelete << cr.imAccount(); ?


- Vishesh Handa


On Feb. 6, 2013, 9:22 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108820/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 9:22 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> = summary.
> 
> 
> This addresses bug 246219.
>     http://bugs.kde.org/show_bug.cgi?id=246219
> 
> 
> Diffs
> -----
> 
>   abstract-storage.h 9218554 
>   account.h e7eb2ee 
>   account.cpp f58a55b 
>   controller.cpp 449a1c4 
>   nepomuk-storage.h 2aab888 
>   nepomuk-storage.cpp 07d3003 
> 
> Diff: http://git.reviewboard.kde.org/r/108820/diff/
> 
> 
> Testing
> -------
> 
> None. Half of my KTp is now on model_refactor_3 and my kpeople branches don't compile, I'm waiting for d_ed (nag) to merge it later tonight (nag nag).
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130207/480bf8ed/attachment.html>