Review Request 107479: Check clientTypes when ordering by presence

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107479/#review26811
-----------------------------------------------------------


Has this been committed? It has Ship It! but still shows open in reviewboard.

- Albert Astals Cid


On Nov. 26, 2012, 6:23 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107479/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 6:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Check clientTypes when ordering by presence
> This patch makes the sorting consider online + on phone as being less 'available' as someone who is just 'online', but still more available than someone who is away.
> 
> I think it's a good idea from my usage but it's not been discussed properly, so comment if you disagree with the idea as well as the code.
> 
> (Also simplified some code just above my patch)
> 
> 
> Diffs
> -----
> 
>   KTp/Models/accounts-filter-model.cpp eeecc77a4e0d776e31b398b91df3504f909b6a41 
> 
> Diff: http://git.reviewboard.kde.org/r/107479/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130206/56c75d1f/attachment.html>