Review Request 108790: Add a class to instantly access the grouped, filtered contacts list model without having to handle proxies ourselves
Martin Klapetek
martin.klapetek at gmail.com
Wed Feb 6 22:12:45 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108790/#review26782
-----------------------------------------------------------
Ship it!
Elegant.
KTp/Models/contacts-model.cpp
<http://git.reviewboard.kde.org/r/108790/#comment20320>
Use local includes too
- Martin Klapetek
On Feb. 6, 2013, 10:04 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108790/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 10:04 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Add a class to instantly access the grouped, filtered contacts list model without having to handle proxies manually.
> This was previously used in ktp-contact-list during porting.
>
> Longer term this will also handle including the MessageModelSource proxy, and possible KPeople.
>
>
> Diffs
> -----
>
> KTp/Models/CMakeLists.txt a95e0c19c816f0cb8a465614fa7e1adecb6d58d1
> KTp/Models/contacts-model.h 2a9cf44736e6e3aea5f92eb09e6840314ba94247
> KTp/Models/contacts-model.cpp 5eb37b1755d3b69961fbed4131ab470c252a29ba
> KTp/types.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/108790/diff/
>
>
> Testing
> -------
>
> Used in the contact-list for a month :)
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130206/f8b514c8/attachment-0001.html>
More information about the KDE-Telepathy
mailing list