Review Request 108720: Fix Message Processor

[Dan Vrátil]

> On Feb. 4, 2013, 2:18 p.m., Dan Vrátil wrote:
> > KTp/Declarative/messages-model.cpp, line 181
> > <http://git.reviewboard.kde.org/r/108720/diff/1/?file=111611#file111611line181>
> >
> >     Since you now have access to Tp::Account you could fix this ;)
> 
> David Edmundson wrote:
>     No I don't.
>     
>     However, this is something I will be fixing in a slightly different way.

d->account ?


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108720/#review26609
-----------------------------------------------------------


On Feb. 6, 2013, 4:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108720/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 4:22 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Generally fix MessageProcessor to match the original design
> 
>  - Make Message constructor private and a friend class of the message processor. This simplifies code, and makes accidentally skipping the escape filtering impossible
>  - Message now has two extra properties isHistory and messageDirection
>  - Message filters have access to the "message context" the account/channel in which the message was received
>  - Remove the broken filterIncomingMessage / filterOutgoingMessages with just one method. Plugins can use messageDirection to get the same functionality
> 
> This is a setup to fix a range of bugs in the message filters
> 
> 
> Diffs
> -----
> 
>   KTp/CMakeLists.txt ed2ab3e2c26903ee359c514deefc6d0042f099c0 
>   KTp/Declarative/conversation.cpp b7a87db6d2cfe002b39c0038e9870a534206e5d2 
>   KTp/Declarative/messages-model.h 162a2487960a876f47848c3a92021faa06aae91e 
>   KTp/Declarative/messages-model.cpp c8b6e8d0bde5e515e156fe59b901eb8227541c76 
>   KTp/abstract-message-filter.h fe85a9ad16960bf8d31cb0968fe9c71867457722 
>   KTp/abstract-message-filter.cpp 111903826fd871eec20c8f5eda54667f24a88d58 
>   KTp/message-backslash-filter.cpp c91522e30a15737c84f53cac98845944a0479aea 
>   KTp/message-context.h PRE-CREATION 
>   KTp/message-context.cpp PRE-CREATION 
>   KTp/message-escape-filter.cpp 696389b0d303be01ea2f79d0389b146ec8773c91 
>   KTp/message-filters-private.h 02e2230c0f8c42d36f61a1010cbe3d584a591670 
>   KTp/message-processor.h 47f66e9c470acb53fc8e25a6bd183e7ccd03b463 
>   KTp/message-processor.cpp 760e36910c7eaf770e31ce122889c02a732a4913 
>   KTp/message-url-filter.cpp 24b652290ea8fbd9349e7a08e609378826ae1c55 
>   KTp/message.h 581a2e20d025a972e8b58ae5e2635a381d000011 
>   KTp/message.cpp d814a996d7e07d0cea70ddcff11ad7e00b904614 
> 
> Diff: http://git.reviewboard.kde.org/r/108720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130206/15b4b20c/attachment-0001.html>