Review Request 108803: Remove more unneeded stuff from nepomuk feeder

David Edmundson david at davidedmundson.co.uk
Wed Feb 6 13:39:09 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108803/#review26751
-----------------------------------------------------------

Ship it!



controller.cpp
<http://git.reviewboard.kde.org/r/108803/#comment20304>

    What do you need FeatureInfo for?
    
    you'll also want FeatureAvatarInfo
    


- David Edmundson


On Feb. 6, 2013, 1:22 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108803/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 1:22 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Removing more unneeded stuff from the feeder. From now on we'll keep in Nepomuk only Telepathy ID, alias and avatar, all the rest will come from the PresencePersonsModel. Also removed are some Tp::Features.
> 
> 
> Diffs
> -----
> 
>   abstract-storage.h 4580a24 
>   account.h 1518aa4 
>   account.cpp 0b89ff5 
>   controller.cpp b33b185 
>   nepomuk-storage.h 60ae252 
>   nepomuk-storage.cpp cdd0b44 
> 
> Diff: http://git.reviewboard.kde.org/r/108803/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130206/2d9113db/attachment.html>


More information about the KDE-Telepathy mailing list