Review Request 108791: Handle Channel.Type.ServerTLSConnection

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108791/#review26681
-----------------------------------------------------------



tls-cert-verifier-op.cpp
<http://git.reviewboard.kde.org/r/108791/#comment20262>

    If it's not DER (could be PGP) it's better to error than to carry on and break.



tls-cert-verifier-op.cpp
<http://git.reviewboard.kde.org/r/108791/#comment20261>

    telepahty spec says this is always a DER
    
    http://telepathy.freedesktop.org/spec/Authentication_TLS_Certificate.html#Simple-Type:Certificate_Data for an x509 cert.
    
    
    



tls-cert-verifier-op.cpp
<http://git.reviewboard.kde.org/r/108791/#comment20263>

    read up on the kdialog crash.
    http://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0
    
    Putting dialog as a QWeakPointer (so it is set to 0 if deleted) should be enough.


- David Edmundson


On Feb. 4, 2013, 11:17 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108791/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2013, 11:17 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Uses QCA2 to verify the certificate chain. CA certs are read from KSslCertificateManager. Exception rules are stored in KSslCertificateManager too. This means that we now share certificates and exceptions with the rest of KDE \o/. However in order to use KSslCertificateManager and KSslInfoDialog I had to import several private headers from kdelibs.
> 
> The dialogs are copied from KIO::TcpSlaveBase, so they look exactly like kio_http.
> 
> If you set a "remember forever" rule during testing and you want to remove it, remove it from ~/.kde/share/config/ksslcertificatemanager and restart KDED.
> 
> I had to remove -DQT_NO_CAST_FROM_ASCII and -DQT_NO_KEYWORDS because QCA2 and kdelibs headers wouldn't compile otherwise.
> 
> 
> This addresses bug 265315.
>     http://bugs.kde.org/show_bug.cgi?id=265315
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 417554a 
>   kssl/kssl.h PRE-CREATION 
>   kssl/ksslcertificatemanager.h PRE-CREATION 
>   kssl/ksslinfodialog.h PRE-CREATION 
>   kssl/ksslsettings.h PRE-CREATION 
>   main.cpp 3350658 
>   tls-cert-verifier-op.h 121cf41 
>   tls-cert-verifier-op.cpp c94999e 
> 
> Diff: http://git.reviewboard.kde.org/r/108791/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130206/0995186f/attachment.html>