Review Request 108780: .desktop-based tubes channel approver

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108780/#review26686
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Feb. 5, 2013, 12:23 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108780/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 12:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Lets see if it really works :)
> 
> Note that the 'Accept' and 'Reject' buttons in Plasma notifications don't work because of https://bugs.kde.org/show_bug.cgi?id=314357 , you have to use the KNotifierItem icon that appears in systray.
> 
> Once this gets committed I'll push respective .desktop files for kwhiteboard
> 
> 
> This addresses bug 301331.
>     http://bugs.kde.org/show_bug.cgi?id=301331
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8b29de7 
>   data/ssh.service PRE-CREATION 
>   ktp-approver.service PRE-CREATION 
>   src/CMakeLists.txt a1ce660 
>   src/approverdaemon.cpp 776a0a2 
>   src/channelapprover.cpp 5d4b02b 
>   src/ktpapprovermodule.cpp db5c005 
>   src/streamtubechannelapprover.h aefe992 
>   src/streamtubechannelapprover.cpp 2a99670 
>   src/textchannelapprover.cpp 0e06a01 
>   src/tubechannelapprover.h PRE-CREATION 
>   src/tubechannelapprover.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108780/diff/
> 
> 
> Testing
> -------
> 
> The best way to test is with KWhiteboard. To do so create /usr/share/kde4/services/ktp/kwhiteboard.desktop:
> 
> [Desktop Entry]
> Type=Service
> X-KDE-ServiceTypes=KTpApprover
> Name=KWhiteboard
> Icon=applications-education
> Comment=User %1 wants to start KWhiteboard session with you
> 
> X-KTp-ChannelType=org.freedesktop.Telepathy.Channel.Type.DBusTube
> X-KTp-Service=org.kde.KWhiteboard
> X-KTp-Cancellable=false
> 
> ...run kbuildsycoca4, restart KDED, load approver module and ask someone to start KWhiteboard session with you.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130205/e1c9cee2/attachment-0001.html>