Review Request 108791: Handle Channel.Type.ServerTLSConnection

Dan Vrátil dvratil at redhat.com
Mon Feb 4 23:17:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108791/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Uses QCA2 to verify the certificate chain. CA certs are read from KSslCertificateManager. Exception rules are stored in KSslCertificateManager too. This means that we now share certificates and exceptions with the rest of KDE \o/. However in order to use KSslCertificateManager and KSslInfoDialog I had to import several private headers from kdelibs.

The dialogs are copied from KIO::TcpSlaveBase, so they look exactly like kio_http.

If you set a "remember forever" rule during testing and you want to remove it, remove it from ~/.kde/share/config/ksslcertificatemanager and restart KDED.

I had to remove -DQT_NO_CAST_FROM_ASCII and -DQT_NO_KEYWORDS because QCA2 and kdelibs headers wouldn't compile otherwise.


This addresses bug 265315.
    http://bugs.kde.org/show_bug.cgi?id=265315


Diffs
-----

  CMakeLists.txt 417554a 
  kssl/kssl.h PRE-CREATION 
  kssl/ksslcertificatemanager.h PRE-CREATION 
  kssl/ksslinfodialog.h PRE-CREATION 
  kssl/ksslsettings.h PRE-CREATION 
  main.cpp 3350658 
  tls-cert-verifier-op.h 121cf41 
  tls-cert-verifier-op.cpp c94999e 

Diff: http://git.reviewboard.kde.org/r/108791/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130204/66b257c6/attachment.html>


More information about the KDE-Telepathy mailing list