Review Request 114121: add sipe/sipe protocol support

[Maksim Melnikau]

> On Dec. 31, 2013, 12:29 p.m., Martin Klapetek wrote:
> > Codewise it looks perfect now, thank you!
> > 
> > Can you please attach a screenshot of the dialog executed from the KCM rather than one from designer?

screenshot attached, but one note here, I have 200 dpi screen, on classic 96 dpi it could look a bit different


- Maksim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114121/#review46480
-----------------------------------------------------------


On Dec. 31, 2013, 12:35 p.m., Maksim Melnikau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114121/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2013, 12:35 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-accounts-kcm
> 
> 
> Description
> -------
> 
> telepathy-sipe e.g. pidgin-sipe telepathy's backend support
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt e752ef1 
>   plugins/sipe/CMakeLists.txt PRE-CREATION 
>   plugins/sipe/Messages.sh PRE-CREATION 
>   plugins/sipe/ktpaccountskcm_plugin_sipe.desktop.cmake PRE-CREATION 
>   plugins/sipe/sipe-account-ui-plugin.h PRE-CREATION 
>   plugins/sipe/sipe-account-ui-plugin.cpp PRE-CREATION 
>   plugins/sipe/sipe-account-ui.h PRE-CREATION 
>   plugins/sipe/sipe-account-ui.cpp PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.h PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.cpp PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.ui PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.h PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.cpp PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114121/diff/
> 
> 
> Testing
> -------
> 
> only basic testing done, not all advanced options tested 
> 
> 
> File Attachments
> ----------------
> 
> sipe kcm
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/5de9f602-db3f-4380-a657-8b91056c69e1__sipe_kcm.png
> 
> 
> Thanks,
> 
> Maksim Melnikau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131231/fd898efb/attachment.html>