Review Request 114523: libkpeople: PersonManager: Fallback to QSQLITE DB driver if QSQLITE3 is not available.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114523/#review46447
-----------------------------------------------------------


This review has been submitted with commit 4a6dabd175d068dcb5afe6b7dc38a8941a06122e by Martin Klapetek to branch master.

- Commit Hook


On Dec. 19, 2013, 5:52 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114523/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 5:52 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> There is said nothing about kpeople dependency on akonadi sqlite driver. At same time, it's said that QMYSQL driver is strongly recommend as Akonadi database backend, so (imo) there is much chance that qsqlite3 driver isn't presented on system, even is akonadi is.
> Currently this case isn't handled at all. Library is making visible that all works, while it didn't. E.g. it return "success" result for PersonManager::mergeContacts() and PersonManager::unmergeContact(), even if it fails to update base. It causes strange behavior in clients app.
> 
> Proposed change introduce fallback to QSQLITE, as lesser evil.
> 
> P.S.: It's hard to understand that QSQLITE3 is correct driver, provided by akonadi. Prefixed with Q instead of K it reject all ideas about kde-relation, while Qt documentation says that driver for SQLite 3 is just "QSQLITE".
> If it worth it, may be someone merge changes to upstream "QSQLITE" driver?
> 
> 
> Diffs
> -----
> 
>   src/personmanager.cpp fd03ba7 
> 
> Diff: https://git.reviewboard.kde.org/r/114523/diff/
> 
> 
> Testing
> -------
> 
> All works good without QSQLITE3 driver. I can't find any issues.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131230/87143589/attachment.html>