Review Request 114121: add sipe/sipe protocol support

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114121/#review46433
-----------------------------------------------------------


For attaching screenshots, there's "Add file" on the top right of the page among the "Update diff" "Review" etc


plugins/sipe/sipe-account-ui-plugin.cpp
<https://git.reviewboard.kde.org/r/114121/#comment33109>

    If the line is too long, always align the arguments below the one on the prev line, eg.
    
    methodName(arg1,
               arg2)



plugins/sipe/sipe-account-ui-plugin.cpp
<https://git.reviewboard.kde.org/r/114121/#comment33110>

    Do we really need this?



plugins/sipe/sipe-account-ui-plugin.cpp
<https://git.reviewboard.kde.org/r/114121/#comment33111>

    This should be parented



plugins/sipe/sipe-account-ui.cpp
<https://git.reviewboard.kde.org/r/114121/#comment33107>

    Can we get this on one line please?
    
    Plus "AbstractAccountParametersWidget *SipeAccountUi" --> 
    
    "AbstractAccountParametersWidget* SipeAccountUi"



plugins/sipe/sipe-account-ui.cpp
<https://git.reviewboard.kde.org/r/114121/#comment33108>

    ...and this



plugins/sipe/sipe-advanced-options-widget.cpp
<https://git.reviewboard.kde.org/r/114121/#comment33112>

    Put on one line


- Martin Klapetek


On Dec. 26, 2013, 10:20 p.m., Maksim Melnikau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114121/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 10:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-accounts-kcm
> 
> 
> Description
> -------
> 
> telepathy-sipe e.g. pidgin-sipe telepathy's backend support
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt e752ef1 
>   plugins/sipe/CMakeLists.txt PRE-CREATION 
>   plugins/sipe/Messages.sh PRE-CREATION 
>   plugins/sipe/ktpaccountskcm_plugin_sipe.desktop.cmake PRE-CREATION 
>   plugins/sipe/sipe-account-ui-plugin.h PRE-CREATION 
>   plugins/sipe/sipe-account-ui-plugin.cpp PRE-CREATION 
>   plugins/sipe/sipe-account-ui.h PRE-CREATION 
>   plugins/sipe/sipe-account-ui.cpp PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.h PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.cpp PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.ui PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.h PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.cpp PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114121/diff/
> 
> 
> Testing
> -------
> 
> only basic testing done, not all advanced options tested 
> 
> 
> Thanks,
> 
> Maksim Melnikau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131230/4fe9a523/attachment-0001.html>