Review Request 114527: Use singleton factory classes from K-C-I

David Edmundson david at davidedmundson.co.uk
Mon Dec 30 10:32:33 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114527/
-----------------------------------------------------------

(Updated Dec. 30, 2013, 10:32 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Repository: ktp-text-ui


Description
-------

Use singleton factory classes from K-C-I

This delays creating an AccountFactory till it's needed, such as
clicking "invite to chat". AccountManager calls becomeReady
immediately which loaded all accounts when we start.

This approach should reduce DBus traffic and get faster load times


Diffs
-----

  app/chat-window.cpp 3d6ee7d 
  app/main.cpp bacd931 
  app/telepathy-chat-ui.h 735a203 
  app/telepathy-chat-ui.cpp b0cf7fc 

Diff: https://git.reviewboard.kde.org/r/114527/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131230/5971d338/attachment.html>


More information about the KDE-Telepathy mailing list