Review Request 114643: Set accountUniqueIdentifier on contacts
Commit Hook
null at kde.org
Sat Dec 28 14:05:22 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114643/#review46286
-----------------------------------------------------------
This review has been submitted with commit 9b73801aa57fb43c612df0e1268b31d1e01a5890 by David Edmundson to branch master.
- Commit Hook
On Dec. 24, 2013, 12:01 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114643/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2013, 12:01 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> Set accountUniqueIdentifier on contacts
>
> Tp::Connection has no method to get the holding Tp::AccountPtr
>
> This makes it difficult to work out which account a contact belongs to.
> This can't be fixed in TpQt in 0.9.x
>
> Instead create a KTp::Account which sets a property on connection
> whenever the connection chanages.
>
> This is exposed from KTp::Contact
>
>
> Diffs
> -----
>
> KTp/CMakeLists.txt 29ee1ab
> KTp/account-factory.cpp PRE-CREATION
> KTp/account-factory_p.h PRE-CREATION
> KTp/contact.h f33a762
> KTp/contact.cpp 52a4f58
> KTp/core.cpp a221e68
>
> Diff: https://git.reviewboard.kde.org/r/114643/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131228/75ab800b/attachment.html>
More information about the KDE-Telepathy
mailing list