Review Request 114671: Block contacts when denying requests

[David Edmundson]

> On Dec. 27, 2013, 3:34 p.m., Dan Vrátil wrote:
> > Is this really the desired behaviour? How do you unblock the contact later when it is not in your contact list?
> 
> David Edmundson wrote:
>     If you deny a contact presence subscription (deny someone seeing when you're online) would you ever want to receive messages from them?
>     
>     There is an option to find and manage blocked contacts from the contact list: Menu -> Show Contacts -> Show Blocked Contacts
>
> 
> Martin Klapetek wrote:
>     Does the option actually include blocked contacts *not* in your roster?

allKnownContacts doesn't return your roster.
It returns every contact that the connection knows about. Blocked, pending subscription replies, etc. which is why we filter when we show the list.

(this poses an interesting off-topic question, what should we expose to kpeople?)


I shall test it to confirm


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114671/#review46189
-----------------------------------------------------------


On Dec. 26, 2013, 4:07 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114671/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 4:07 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Block contacts when denying requests
> 
> 
> This should fix the bugs of contacts reappearing.
> 
> 
> Diffs
> -----
> 
>   contact-request-handler.cpp 014b9cb 
> 
> Diff: https://git.reviewboard.kde.org/r/114671/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131228/3ec925c8/attachment.html>