Review Request 114366: Share a single Akonadi::Monitor between all AkonadiContact instances

[Martin Klapetek]

> On Dec. 9, 2013, 5:27 p.m., Dan Vrátil wrote:
> > You can optimize the fetchscope of both monitors a little to reduces the amount of data server has to get from database and transmit to client.
> > 
> > m_monitor->itemFetchScope().setFetchModificationTime(false);
> > m_monitor->itemFetchScope().setFetchRemoteIdentification(false);
> 
> Martin Klapetek wrote:
>     Note that this is (yet-unreleased) 4.12 API. As it was pushed, we must now either make kdepim-libs 4.12 REQUIRED or remove/ifdef those lines, otherwise we're getting build failures with 4.11 kdepim-libs.
> 
> Dan Vrátil wrote:
>     Only fetchRemoteIdentification(). Sorry for that, being constantly on master I'm losing track of versions and API changes.
> 
> Martin Klapetek wrote:
>     Np, happened to me too many times as well :)
>     
>     Would ifdefing that one call be ok? I know it's not helping much with Akonadi's performance, but I think hard-depending on 4.12 now is not very good.
> 
> Dan Vrátil wrote:
>     You can just remove it completely if you want to avoid ifdefs. It really just excludes one column from an SQL query in Akonadi server and saves about 30 characters in the response sent to clients, so the gain on both sides is very very small. It's most useful in KMail, where not storing (tens of) thousands of strings in memory makes a bigger difference.

I went for ifdefs. Every little performance gain counts :P


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114366/#review45406
-----------------------------------------------------------


On Dec. 11, 2013, 10:57 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114366/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 10:57 p.m.)
> 
> 
> Review request for Telepathy and Dan Vrátil.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Share a single Akonadi::Monitor between all AkonadiContact instances
> 
> 
> Diffs
> -----
> 
>   src/plugins/akonadi/akonadidatasource.h b09edf8 
>   src/plugins/akonadi/akonadidatasource.cpp 193de78 
> 
> Diff: https://git.reviewboard.kde.org/r/114366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131228/5e9a769d/attachment-0001.html>