Review Request 114688: Set KPEOPLE_VERSION in FindKPeople file

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114688/#review46266
-----------------------------------------------------------



cmake/FindKPeople.cmake
<https://git.reviewboard.kde.org/r/114688/#comment33027>

    I think we should also set the *VERSION_MAJOR *_MINOR and stuff, like -->
    
    set(KPEOPLE_VERSION_MAJOR @KPEOPLE_VERSION_MAJOR@)
    set(KPEOPLE_VERSION_MINOR @KPEOPLE_VERSION_MINOR@)
    set(KPEOPLE_VERSION_PATCH @KPEOPLE_VERSION_PATCH@)
    set(KPEOPLE_VERSION       "${KPEOPLE_VERSION_MAJOR}.${KPEOPLE_VERSION_MINOR}.${KPEOPLE_VERSION_PATCH}")
    
    However that requires those strings to be set in CMakeLists.txt too.
    
    Opinions?


- Martin Klapetek


On Dec. 27, 2013, 8:21 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114688/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 8:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Set KPEOPLE_VERSION in FindKPeople file
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 682cb16 
>   cmake/FindKPeople.cmake 399d8ed 
> 
> Diff: https://git.reviewboard.kde.org/r/114688/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131228/cd7b6886/attachment.html>