Review Request 114670: Make sure we emit the correct subcontact indexes when changing rows

[David Edmundson]

> On Dec. 27, 2013, 3:32 p.m., Dan Vrátil wrote:
> > src/metacontact.cpp, line 55
> > <https://git.reviewboard.kde.org/r/114670/diff/1/?file=227189#file227189line55>
> >
> >     insertContact() calls reaload() itself, it's probably not necessary to do it twice?
> >     
> >     Also since reload() looks expensive, maybe you don't want to call it for every insertContact(), but just once after?

Good point.

though insertContact can also be called externally from the PersonsModel/PersonData

I guess I want some sort of:

insertContact()
{
 insertContactInternal();
 reload();
}

insertContactInternal()
{
//old insertContact code here
}


> On Dec. 27, 2013, 3:32 p.m., Dan Vrátil wrote:
> > src/personsmodel.cpp, line 209
> > <https://git.reviewboard.kde.org/r/114670/diff/1/?file=227191#file227191line209>
> >
> >     s/practive/practice/
> >     
> >     Also: if I understand it correctly, personChanged() emits notification about change of the parent row of the rows just inserted. So it makes sense to call personChanged() after endInsertRows(), which ensures the new rows are already in the view. I think the code is just fine and the NOTE is not neccesary.
> >

yep you understood the bit about updating the contact then updating the person correctly.

What it is wrong is I do:
 - add row to my list
 - beginInsert()
 - endInsert()

rather than
 - beginInsert()
 - add row
 - endInsert()

which is what I meant to put the comment about.

But I don't know how else to do it without calculating things twice.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114670/#review46188
-----------------------------------------------------------


On Dec. 26, 2013, 3:10 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114670/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 3:10 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Make sure we emit the correct subcontact model index when adding/removing/changing subcontacts
> 
> 
> Diffs
> -----
> 
>   src/metacontact.cpp 92d4e61 
>   src/metacontact_p.h 7b36773 
>   src/personsmodel.cpp c447730 
> 
> Diff: https://git.reviewboard.kde.org/r/114670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131227/7ea6038a/attachment.html>