Review Request 114121: add sipe/sipe protocol support

[Maksim Melnikau]

> On Nov. 26, 2013, 9:18 a.m., David Edmundson wrote:
> > plugins/sipe/sipe-advanced-options-widget.ui, line 1
> > <https://git.reviewboard.kde.org/r/114121/diff/1/?file=220054#file220054line1>
> >
> >     Is this the same as haze/sipe-advanced-options-widget.ui
> >     
> >     Do you see the two sets of options diverging? If so it might be a good idea to re-use the same file.

They are similar, but not the same. For some reason haze/sipe and sipe/sipe provides different settings via dbus. 


- Maksim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114121/#review44479
-----------------------------------------------------------


On Dec. 26, 2013, 9:20 p.m., Maksim Melnikau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114121/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 9:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-accounts-kcm
> 
> 
> Description
> -------
> 
> telepathy-sipe e.g. pidgin-sipe telepathy's backend support
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt e752ef1 
>   plugins/sipe/CMakeLists.txt PRE-CREATION 
>   plugins/sipe/Messages.sh PRE-CREATION 
>   plugins/sipe/ktpaccountskcm_plugin_sipe.desktop.cmake PRE-CREATION 
>   plugins/sipe/sipe-account-ui-plugin.h PRE-CREATION 
>   plugins/sipe/sipe-account-ui-plugin.cpp PRE-CREATION 
>   plugins/sipe/sipe-account-ui.h PRE-CREATION 
>   plugins/sipe/sipe-account-ui.cpp PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.h PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.cpp PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.ui PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.h PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.cpp PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114121/diff/
> 
> 
> Testing
> -------
> 
> only basic testing done, not all advanced options tested 
> 
> 
> Thanks,
> 
> Maksim Melnikau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131226/d5225e66/attachment-0001.html>