Review Request 114121: add sipe/sipe protocol support

Maksim Melnikau maxposedon at gmail.com
Thu Dec 26 21:20:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114121/
-----------------------------------------------------------

(Updated Dec. 26, 2013, 9:20 p.m.)


Review request for Telepathy.


Changes
-------

1. adjust layout for ui files
2. remove multi-line method definitions
3. add ":" in forms
4. replace "don't" with "do not"


Repository: ktp-accounts-kcm


Description
-------

telepathy-sipe e.g. pidgin-sipe telepathy's backend support


Diffs (updated)
-----

  plugins/CMakeLists.txt e752ef1 
  plugins/sipe/CMakeLists.txt PRE-CREATION 
  plugins/sipe/Messages.sh PRE-CREATION 
  plugins/sipe/ktpaccountskcm_plugin_sipe.desktop.cmake PRE-CREATION 
  plugins/sipe/sipe-account-ui-plugin.h PRE-CREATION 
  plugins/sipe/sipe-account-ui-plugin.cpp PRE-CREATION 
  plugins/sipe/sipe-account-ui.h PRE-CREATION 
  plugins/sipe/sipe-account-ui.cpp PRE-CREATION 
  plugins/sipe/sipe-advanced-options-widget.h PRE-CREATION 
  plugins/sipe/sipe-advanced-options-widget.cpp PRE-CREATION 
  plugins/sipe/sipe-advanced-options-widget.ui PRE-CREATION 
  plugins/sipe/sipe-main-options-widget.h PRE-CREATION 
  plugins/sipe/sipe-main-options-widget.cpp PRE-CREATION 
  plugins/sipe/sipe-main-options-widget.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114121/diff/


Testing
-------

only basic testing done, not all advanced options tested 


Thanks,

Maksim Melnikau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131226/be8a157c/attachment.html>


More information about the KDE-Telepathy mailing list