Review Request 114621: Create an account directly in PersistentContact without going via AccountManager

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114621/
-----------------------------------------------------------

(Updated Dec. 23, 2013, 7:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Repository: ktp-common-internals


Description
-------

Create an account directly in PersistentContact

This saves having to create an AccountManager to load contact info which in turn saves having to load every account from DBus in order to get one account's info.


Will make the API neater too as we will no longer have to wait and load an AccountManager first.


Diffs
-----

  KTp/persistent-contact.h f5367a3 
  KTp/persistent-contact.cpp 919fad1 

Diff: https://git.reviewboard.kde.org/r/114621/diff/


Testing
-------

Using (my unpushed) KTp KPeople::ContactMonitor the KPeople personwidget example loads presence _instantly_. Bustle confirms it is using a lot less traffic, without libpurple spamming constantly if I am not accessing a libpurple account.

I also expect this to be the preferred way to get the ContactPtr in KTp's kpeople UI/actions plugins.

Theoretically this will also make the plasma quick chat applet laod faster - but will require some changes before that actually happens.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131223/35de382e/attachment.html>