Review Request 114526: Expose DbusProxy factories as singleton objects

Martin Klapetek martin.klapetek at gmail.com
Mon Dec 23 15:12:01 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114526/#review46089
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Klapetek


On Dec. 18, 2013, 4:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114526/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2013, 4:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Expose DbusProxy factories as singleton objects
> 
> Having a singleton AccountManager is problematic because we often
> need advanced channel factories for applications and don't want
> to increase dbus traffic in other applications.
> 
> By exposing factories individually we can create custom client
> registrars with differnet channel factories whilst sharing the
> expensive account, connection and contact objects.
> 
> 
> Diffs
> -----
> 
>   KTp/core.h 9db9cf4 
>   KTp/core.cpp 783b7cd 
> 
> Diff: https://git.reviewboard.kde.org/r/114526/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131223/8d8dac40/attachment-0001.html>


More information about the KDE-Telepathy mailing list