Review Request 114559: Only try loading data from the relevant data source

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114559/
-----------------------------------------------------------

(Updated Dec. 23, 2013, 2:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Repository: libkpeople


Description
-------

Only try loading data from the relevant data source

i.e only query akonadi for contacts starting with akonadi://


Thoughts: 
 - should this be a pure virtual method in the data source or a property in the .desktop file?

 - the parsing of the IDs to get the sourceId from the url-looking string is a bit rubbish, in a future patch I'll tidy this up with an ID class that doesn't have this horrible string parsing.


Note this is an ABI break. 


Diffs
-----

  src/basepersonsdatasource.h 12f698e 
  src/persondata.cpp 277fa6b 
  src/personpluginmanager.h adc7b9d 
  src/personpluginmanager.cpp e433bb5 
  src/plugins/akonadi/akonadidatasource.h ef5c602 
  src/plugins/akonadi/akonadidatasource.cpp b640d00 

Diff: https://git.reviewboard.kde.org/r/114559/diff/


Testing
-------

Opened PersonViewer


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131223/206fc85e/attachment.html>