Review Request 114605: Restore libkpeople unit tests

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114605/
-----------------------------------------------------------

(Updated Dec. 23, 2013, 12:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Repository: libkpeople


Description
-------

Add tests for PersonData


Add method to override DataSources used for testing


Remove old nepomuk tests


Add hook to alter the personsDB used

For making unit tests


Remove unused include


---------------

I haven't tested all the things I want; I really want to test the model especially with lots of merging/unmerging


Diffs
-----

  src/CMakeLists.txt 43e1008 
  src/autotests/fakecontactsource.h PRE-CREATION 
  src/autotests/fakecontactsource.cpp PRE-CREATION 
  src/autotests/lib/CMakeLists.txt 2358e8b 
  src/autotests/lib/NepomukTestLibMacros.cmake.in 5189462 
  src/autotests/lib/datagenerator.h 6e75b67 
  src/autotests/lib/datagenerator.cpp 630585a 
  src/autotests/lib/nepomukserverrc.in 27b5c90 
  src/autotests/lib/nepomuktest_export.h 38a8eaa 
  src/autotests/lib/testbase.h 6d2a6b3 
  src/autotests/lib/testbase.cpp 954fc83 
  src/autotests/lib/tools/CMakeLists.txt 2e24962 
  src/autotests/lib/tools/dbus-session-begin.sh ac0e63a 
  src/autotests/lib/tools/dbus-session-end.sh 4a13a05 
  src/autotests/lib/tools/nepomuk-sandbox-begin.sh.in a755590 
  src/autotests/lib/tools/nepomuk-sandbox-end.sh.in e331cb0 
  src/autotests/lib/tools/runNepomukTest.sh.in 18c73f9 
  src/autotests/persondatatests.h PRE-CREATION 
  src/autotests/persondatatests.cpp PRE-CREATION 
  src/autotests/tests/CMakeLists.txt 63e6739 
  src/autotests/tests/duplicatestests.h 2faed15 
  src/autotests/tests/duplicatestests.cpp 4083825 
  src/autotests/tests/persondatatests.h 90ec2a2 
  src/autotests/tests/persondatatests.cpp bf0c470 
  src/personmanager.cpp fd03ba7 
  src/personmanager_p.h e334f53 
  src/personpluginmanager.h adc7b9d 
  src/personpluginmanager.cpp e433bb5 

Diff: https://git.reviewboard.kde.org/r/114605/diff/


Testing
-------

Tested my new tests!


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131223/c06e6b83/attachment.html>