Review Request 114584: Exciting cleanups

[David Edmundson]

> On Dec. 23, 2013, 12:11 p.m., Martin Klapetek wrote:
> > src/allcontactsmonitor.cpp, line 36
> > <https://git.reviewboard.kde.org/r/114584/diff/1/?file=226769#file226769line36>
> >
> >     Why we don't parent this?

they're ref counted inside BasePersonsDataSource


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114584/#review46074
-----------------------------------------------------------


On Dec. 21, 2013, 3:18 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114584/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2013, 3:18 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> D pointer and namespace AllContactsMonitor
> 
> 
> Diffs
> -----
> 
>   src/allcontactsmonitor.h 4a12696 
>   src/allcontactsmonitor.cpp 37a19cc 
>   src/plugins/akonadi/akonadidatasource.h 4eeb511 
>   src/plugins/akonadi/akonadidatasource.cpp 620dfee 
> 
> Diff: https://git.reviewboard.kde.org/r/114584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131223/63e0b866/attachment.html>