Review Request 114621: Create an account directly in PersistentContact without going via AccountManager

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114621/#review46073
-----------------------------------------------------------

Ship it!



KTp/persistent-contact.h
<https://git.reviewboard.kde.org/r/114621/#comment32879>

    I'd suggest to add "KDE_DEPRECATED" so one gets compiler warning if using this.



KTp/persistent-contact.cpp
<https://git.reviewboard.kde.org/r/114621/#comment32877>

    onAccountReady maybe? We're not "creating" account
    
    Also * -> *op



KTp/persistent-contact.cpp
<https://git.reviewboard.kde.org/r/114621/#comment32878>

    I guess these two could be merged into one line...but, meh..


- Martin Klapetek


On Dec. 22, 2013, 7:49 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114621/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2013, 7:49 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Create an account directly in PersistentContact
> 
> This saves having to create an AccountManager to load contact info which in turn saves having to load every account from DBus in order to get one account's info.
> 
> 
> Will make the API neater too as we will no longer have to wait and load an AccountManager first.
> 
> 
> Diffs
> -----
> 
>   KTp/persistent-contact.h f5367a3 
>   KTp/persistent-contact.cpp 919fad1 
> 
> Diff: https://git.reviewboard.kde.org/r/114621/diff/
> 
> 
> Testing
> -------
> 
> Using (my unpushed) KTp KPeople::ContactMonitor the KPeople personwidget example loads presence _instantly_. Bustle confirms it is using a lot less traffic, without libpurple spamming constantly if I am not accessing a libpurple account.
> 
> I also expect this to be the preferred way to get the ContactPtr in KTp's kpeople UI/actions plugins.
> 
> Theoretically this will also make the plasma quick chat applet laod faster - but will require some changes before that actually happens.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131223/afe99b1a/attachment.html>