Review Request 114577: Boring cleanups

[David Edmundson]

> On Dec. 21, 2013, 12:14 a.m., Martin Klapetek wrote:
> > src/basepersonsdatasource.cpp, lines 25-29
> > <http://git.reviewboard.kde.org/r/114577/diff/1/?file=226745#file226745line25>
> >
> >     Having two namespace declarations is useless, let's extend the namespace KPeople { .. } to the whole file

Well we tend to use "using namespace " in our libkpeople cpp files, I don't want to have a mix.

This was wrong before though, we shouldn't be doing a using namespace before an include, that will potentially mask errors.


I've changed it to


#includes...

using namespace KPeople;

struct KPeople::ContactMonitorPrivate {

};

So there's still just the one namespace call

This matches what PIM does.


On Dec. 21, 2013, 12:14 a.m., David Edmundson wrote:
> > Sorry to make your work more boring ;)

Bane of my life.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114577/#review45973
-----------------------------------------------------------


On Dec. 20, 2013, 8:59 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114577/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 8:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> D Pointer ContactMonitor and add KPeople namespace
> 
> 
> D pointer BasePersonsDataSource
> 
> 
> Diffs
> -----
> 
>   src/basepersonsdatasource.h 12f698e 
>   src/basepersonsdatasource.cpp c416b3b 
>   src/contactmonitor.h b921d92 
>   src/contactmonitor.cpp e20f491 
>   src/defaultcontactmonitor_p.h 797ac8a 
>   src/plugins/akonadi/akonadidatasource.h ef5c602 
>   src/plugins/akonadi/akonadidatasource.cpp b640d00 
> 
> Diff: http://git.reviewboard.kde.org/r/114577/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131221/857cbc84/attachment.html>