Review Request 114444: Make nick completion style configurable

Leon Handreke leonh at ndreke.de
Wed Dec 18 16:14:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114444/
-----------------------------------------------------------

(Updated Dec. 18, 2013, 4:14 p.m.)


Review request for Telepathy.


Changes
-------

Renamed everyting s/nameCompletion/nicknameCompletion/ for consistency with the UI. Improved the UI a bit.


Bugs: 326756
    http://bugs.kde.org/show_bug.cgi?id=326756


Repository: ktp-text-ui


Description
-------

Make nick completion style configurable


Diffs (updated)
-----

  config/behavior-config.h fcbdd7f678a8d975751c44afbdcda61771a59f8b 
  config/behavior-config.cpp 9f863dca930f1b39587fc63207d1c92d096a6559 
  config/behavior-config.ui 200f6ee4023e11e9101dd10774d8095fab2e0120 
  lib/chat-text-edit.cpp 4e0f0305b7ae18062f695eb26ee681a0c64aaf26 
  lib/text-chat-config.h 603c00615d8bd51249ebff4e14fa5b44a2e5af0a 
  lib/text-chat-config.cpp 7425d5ea03b67022db813c2fffcdcb51c572e759 

Diff: http://git.reviewboard.kde.org/r/114444/diff/


Testing
-------

Clicked around in the UI, verified that all options work.


File Attachments (updated)
----------------

Screenshot of the config UI
  http://git.reviewboard.kde.org/media/uploaded/files/2013/12/18/98c4ac3e-88ba-4ae9-a9de-14287169fa8d__nickname-completion-screenshot.png


Thanks,

Leon Handreke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131218/ee9fbab2/attachment.html>


More information about the KDE-Telepathy mailing list