Review Request 114480: Preferences button behaviour has been fixed and adjusted

[Illya Kovalevskyy]

> On Dec. 16, 2013, 11:44 a.m., Martin Klapetek wrote:
> > Yes, the reason is that if you click the icon instead of the tiny down-arrow, it wouldn't work (in this patch it opens the accounts KCM). Which imho makes the menu either a hardly discoverable (you usually click the icon) and/or hard-to-hit target (the menu displaying arrow is just couple pixels).
> > 
> > Furthermore, their focus rect is separated and it looks weird. I wonder how Dolphin does it...however, this is not a way I'd like to approve, sorry.
> 
> Martin Klapetek wrote:
>     The core of the problem lies in the docs:
>     
>     "When a QToolBar is not a child of a QMainWindow, it loses the ability to populate the extension pop up with widgets added to the toolbar using addWidget(). Please use widget actions created by inheriting QWidgetAction and implementing QWidgetAction::createWidget() instead."
>     
>     So your options are either
>     1) Make the QToolBar child of QMainWindow (might be tricky)
>     2) Create a special QWidgetAction class which reimplements QWidgetAction::createWidget() (easier imho, but longer to finish)
>     
>     I'm fine if you leave this task for now and I'll do it later, but of course if you're up to the challenge, patches welcome :)

It's awesome for me, I'll do my best to fix it.


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114480/#review45758
-----------------------------------------------------------


On Dec. 15, 2013, 7:22 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114480/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 7:22 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Martin Klapetek.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5845533033758720) and a KDE Bug (https://bugs.kde.org/show_bug.cgi?id=316591):
> 
> Now, preferences tool icon is a QToolButton basically, so it's not an actual visual children (in terms of UI/UX) of the tool bar and its behaviour is broken: when you decrese contact list, so it hides it's not displayed inside additional action list (right arrow), because it's not an action.
> 
> This patch fixes it's behaviour by making this a QAction + adjusting some stuff
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp 93574d9 
> 
> Diff: http://git.reviewboard.kde.org/r/114480/diff/
> 
> 
> Testing
> -------
> 
> Visually looks good and no compiler/runtime/console errors.
> 
> 
> File Attachments
> ----------------
> 
> Regular view
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/d6f2c653-37a5-461d-9624-4f6e5df67281__Window-Regular.png
> Window narrowed
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/21ef3aa3-a969-489c-938c-0af7cb5f3556__Window-Narrow.png
> Bugfix "in action"
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/e6348ed3-b722-49fe-95fe-9e8384b04214__Window-Exposed.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131216/efaf921f/attachment.html>