Review Request 114366: Share a single Akonadi::Monitor between all AkonadiContact instances

[Martin Klapetek]

> On Dec. 9, 2013, 4:27 p.m., Dan Vrátil wrote:
> > You can optimize the fetchscope of both monitors a little to reduces the amount of data server has to get from database and transmit to client.
> > 
> > m_monitor->itemFetchScope().setFetchModificationTime(false);
> > m_monitor->itemFetchScope().setFetchRemoteIdentification(false);
> 
> Martin Klapetek wrote:
>     Note that this is (yet-unreleased) 4.12 API. As it was pushed, we must now either make kdepim-libs 4.12 REQUIRED or remove/ifdef those lines, otherwise we're getting build failures with 4.11 kdepim-libs.
> 
> Dan Vrátil wrote:
>     Only fetchRemoteIdentification(). Sorry for that, being constantly on master I'm losing track of versions and API changes.

Np, happened to me too many times as well :)

Would ifdefing that one call be ok? I know it's not helping much with Akonadi's performance, but I think hard-depending on 4.12 now is not very good.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114366/#review45406
-----------------------------------------------------------


On Dec. 11, 2013, 9:57 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114366/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 9:57 p.m.)
> 
> 
> Review request for Telepathy and Dan Vrátil.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Share a single Akonadi::Monitor between all AkonadiContact instances
> 
> 
> Diffs
> -----
> 
>   src/plugins/akonadi/akonadidatasource.h b09edf8 
>   src/plugins/akonadi/akonadidatasource.cpp 193de78 
> 
> Diff: http://git.reviewboard.kde.org/r/114366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131212/8b7de04a/attachment.html>