Review Request 114137: Plasmoid Contact: Partially port ContactWrapper to KTp::Contact.

Commit Hook null at kde.org
Thu Dec 5 15:55:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114137/#review45208
-----------------------------------------------------------


This review has been submitted with commit df9b026f23ec6627b06d5a36d1a1e6090b941630 by Alexandr Akulich to branch master.

- Commit Hook


On Dec. 5, 2013, 12:45 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114137/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 12:45 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Port ContactWrapper capability getters from deprecated methods in Tp::CapabilitiesBase to proper ones in KTp::Contact.
> Next portion is to use KTp::Contact::avatarPixmap(), but it's delayed until contacts and avatars cache be implemented.
> 
> 
> Diffs
> -----
> 
>   contact/src/contact-wrapper.h 0271dd4 
>   contact/src/contact-wrapper.cpp 6a6af5a 
>   contact/src/declarative/contents/ui/DropDownMenu.qml 234d6b9 
>   contact/src/telepathy-contact.cpp a768d6f 
> 
> Diff: http://git.reviewboard.kde.org/r/114137/diff/
> 
> 
> Testing
> -------
> 
> Capability getters works as expected.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131205/d33e9572/attachment.html>


More information about the KDE-Telepathy mailing list