Review Request 114137: Plasmoid Contact: Partially port ContactWrapper to KTp::Contact.

Alexandr Akulich akulichalexander at gmail.com
Thu Dec 5 12:45:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114137/
-----------------------------------------------------------

(Updated Dec. 5, 2013, 6:45 p.m.)


Review request for Telepathy.


Changes
-------

Implemented canStartTextChat property.

TelepathyContact: accountForPath() -> accountForObjectPath().


Repository: ktp-desktop-applets


Description
-------

Port ContactWrapper capability getters from deprecated methods in Tp::CapabilitiesBase to proper ones in KTp::Contact.
Next portion is to use KTp::Contact::avatarPixmap(), but it's delayed until contacts and avatars cache be implemented.


Diffs (updated)
-----

  contact/src/contact-wrapper.h 0271dd4 
  contact/src/contact-wrapper.cpp 6a6af5a 
  contact/src/declarative/contents/ui/DropDownMenu.qml 234d6b9 
  contact/src/telepathy-contact.cpp a768d6f 

Diff: http://git.reviewboard.kde.org/r/114137/diff/


Testing
-------

Capability getters works as expected.


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131205/121df8b4/attachment.html>


More information about the KDE-Telepathy mailing list