Review Request 111501: Fix LaTeX filter

Commit Hook null at kde.org
Fri Aug 30 10:25:47 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111501/
-----------------------------------------------------------

(Updated Aug. 30, 2013, 10:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy and Andrea Scarpino.


Description
-------

Fix LaTeX filter

Instead of trying to put the images inline we put a reference and insert the LaTeX images at the end.

The "appended message parts" aren't affected by other filters.


Diffs
-----

  filters/latex/latex-filter.cpp 4e9601f095c1a3790e719b1cbbd1f32ed75c0424 

Diff: http://git.reviewboard.kde.org/r/111501/diff/


Testing
-------

currently code renders as <img src=".... because we run before the escape filter. 

If we run after we get bugs because we escape before the LaTeX can get the original code.

This fixes both of them, and makes it clearer for larger amounts of text, as otherwise line heights get confusing.


File Attachments
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/formula.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130830/6dc0d526/attachment.html>


More information about the KDE-Telepathy mailing list