Review Request 112346: Test for kpeople at runtime

David Edmundson david at davidedmundson.co.uk
Thu Aug 29 13:35:38 UTC 2013



> On Aug. 29, 2013, 1:32 p.m., Dan Vrátil wrote:
> > contact-list-widget.cpp, line 740
> > <http://git.reviewboard.kde.org/r/112346/diff/1/?file=185543#file185543line740>
> >
> >     Isn't this block indented one tab too much? 
> >     Compare it with the if() block above.

It was.
Thanks


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112346/#review38854
-----------------------------------------------------------


On Aug. 28, 2013, 11:29 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112346/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 11:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Test for kpeople at runtime
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp 98119a55a6860f72a710229513190a757dff1a0e 
>   context-menu.cpp d3d84daffe374afecb15cb9198dbaf0221fab1d6 
> 
> Diff: http://git.reviewboard.kde.org/r/112346/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130829/8632757d/attachment.html>


More information about the KDE-Telepathy mailing list