Review Request 112344: Add namespace function isKPeopleEnabled

Martin Klapetek martin.klapetek at gmail.com
Wed Aug 28 22:55:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112344/#review38817
-----------------------------------------------------------


You forgot to add the core.h/.cpp files ;)


KTp/Models/contacts-model.cpp
<http://git.reviewboard.kde.org/r/112344/#comment28681>

    } else {


- Martin Klapetek


On Aug. 28, 2013, 5:53 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112344/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 5:53 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add namespace function isKPeopleEnabled
> 
> Add namespace function isKPeopleEnabled. This makes it easier for apps
> to do runtime checking similar to that originally in the ContactsModel.
> 
> + remove random nonsensical comment in types.h
> 
> 
> Diffs
> -----
> 
>   KTp/CMakeLists.txt 89b0721e6785a8ee2ef4337b7620bed0f30f1a72 
>   KTp/Models/contacts-model.cpp b24e4ee1e9bf17d71c0f10fd38a94cbb044bce4f 
>   KTp/types.h 7980c3c5f68cd5ce0fc97cfe56d4857d305d58f2 
> 
> Diff: http://git.reviewboard.kde.org/r/112344/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130828/eec0c88e/attachment.html>


More information about the KDE-Telepathy mailing list