Review Request 112306: Change runner name + comment to clarify it does more than just contacts

Thomas Pfeiffer colomar at autistici.org
Tue Aug 27 08:42:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112306/#review38717
-----------------------------------------------------------



plasma-runner-ktp-contact.desktop.cmake
<http://git.reviewboard.kde.org/r/112306/#comment28598>

    I'd change "and" to "or" because you don't do both with a single command


- Thomas Pfeiffer


On Aug. 27, 2013, 2:35 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112306/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 2:35 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Change runner name + comment to clarify it does more than just contacts
> 
> 
> Diffs
> -----
> 
>   plasma-runner-ktp-contact.desktop.cmake 709d6f95992af90cb194e36112962d48066d40a1 
> 
> Diff: http://git.reviewboard.kde.org/r/112306/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130827/bcb66b80/attachment.html>


More information about the KDE-Telepathy mailing list