Review Request 112181: Update context menu of presence applet when custom presence changes

[Siddhartha Sahu]

> On Aug. 21, 2013, 9:56 a.m., David Edmundson wrote:
> > presence-model.cpp, line 54
> > <http://git.reviewboard.kde.org/r/112181/diff/1/?file=183709#file183709line54>
> >
> >     this probably needs a config.sync() somewhere.

there is a sync command at the end


> On Aug. 21, 2013, 9:56 a.m., David Edmundson wrote:
> > presence-model.cpp, line 179
> > <http://git.reviewboard.kde.org/r/112181/diff/1/?file=183709#file183709line179>
> >
> >     This is a synchronous dbus call. These are almost always bad.
> >     
> >     We block the contact-list running until the kernel switches to plasma and plasma runs processes it then returns back.
> >     
> >     With heavy dbus traffic or plasma being rubbish it's very easy to lock up our app.
> >     
> >     In this particular case the return value is not very useful and not used.
> >     We can make this async and ignore the reply.

Have changed dbus call to async


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112181/#review38263
-----------------------------------------------------------


On Aug. 22, 2013, 2:23 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112181/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 2:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add Dbus messaging when custom presence is added or removed. This updates the context menu of presence applet
> 
> 
> This addresses bug 317550.
>     http://bugs.kde.org/show_bug.cgi?id=317550
> 
> 
> Diffs
> -----
> 
>   dialogs/custom-presence-dialog.cpp 11aadb9 
>   presence-model.h dcb9ccc 
>   presence-model.cpp 72bfc3d 
> 
> Diff: http://git.reviewboard.kde.org/r/112181/diff/
> 
> 
> Testing
> -------
> 
> Done locally from master. Adding and removing presences changes context menu successfully
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130822/3695d953/attachment.html>